Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper handling of empty folder #328

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Proper handling of empty folder #328

merged 2 commits into from
Sep 15, 2023

Conversation

xinaxu
Copy link
Contributor

@xinaxu xinaxu commented Sep 15, 2023

Empty folder from supported backends will now have a database entry.

resolves #220

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 51.42% and project coverage change: -0.01% ⚠️

Comparison is base (d0a6c36) 73.93% compared to head (fc3bbdd) 73.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
- Coverage   73.93%   73.92%   -0.01%     
==========================================
  Files         136      136              
  Lines        8533     8561      +28     
==========================================
+ Hits         6309     6329      +20     
- Misses       1565     1570       +5     
- Partials      659      662       +3     
Files Changed Coverage Δ
storagesystem/types.go 96.10% <ø> (ø)
storagesystem/rclone.go 85.29% <50.00%> (-2.29%) ⬇️
scan/scan.go 58.94% <52.63%> (-1.58%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xinaxu xinaxu merged commit ac6227b into main Sep 15, 2023
@xinaxu xinaxu deleted the xinaxu/empty-folder branch September 15, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty directory is not handled during data prep
1 participant