Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set mime to application/vnd.ipld.car for exported CAR files #321

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

xinaxu
Copy link
Contributor

@xinaxu xinaxu commented Sep 14, 2023

resolves #316

storagesystem/rclone.go Outdated Show resolved Hide resolved
@xinaxu xinaxu requested a review from willscott September 14, 2023 19:26
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03% ⚠️

Comparison is base (cc539ec) 73.72% compared to head (b7b7348) 73.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
- Coverage   73.72%   73.69%   -0.03%     
==========================================
  Files         134      134              
  Lines        8204     8207       +3     
==========================================
  Hits         6048     6048              
- Misses       1518     1520       +2     
- Partials      638      639       +1     
Files Changed Coverage Δ
storagesystem/rclone.go 82.65% <100.00%> (+0.54%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xinaxu xinaxu changed the title Set mime to application/car for exported CAR files Set mime to application/vnd.ipld.car for exported CAR files Sep 14, 2023
@xinaxu xinaxu merged commit 780453d into main Sep 14, 2023
@xinaxu xinaxu deleted the xinaxu/car-mime branch September 14, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set mime to application/car for exported CAR files
2 participants