Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add output storages to CLI output #306

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Add output storages to CLI output #306

merged 1 commit into from
Sep 13, 2023

Conversation

xinaxu
Copy link
Contributor

@xinaxu xinaxu commented Sep 13, 2023 •
edited
Loading

solves #293

willscott
willscott approved these changes Sep 13, 2023
View reviewed changes
handler/job/status.go
@@ -37,7 +38,7 @@ type SourceStatus struct {
func (DefaultHandler) GetStatusHandler(ctx context.Context, db *gorm.DB, id string) ([]SourceStatus, error) {
db = db.WithContext(ctx)
var preparation model.Preparation
err := preparation.FindByIDOrName(db, id)
err := preparation.FindByIDOrName(db, id, "OutputStorages")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe make this a const

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're using those literals everywhere unfortunately.

@xinaxu
Copy link
Contributor Author

xinaxu commented Sep 13, 2023

Some temporary test failure caused by glif issue.

@xinaxu xinaxu merged commit 72cbd09 into main Sep 13, 2023
@xinaxu xinaxu deleted the xinaxu/status-output-storages branch September 13, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willscott willscott willscott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xinaxu @willscott