Use consistent id type across handlers #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Investigating `Invalid handler function signature` on hitting
`/api/file/{id}/deals` via the hand-rolled HTTP Client library. The
parameter types across get source file and get source file deals is
inconsistent. consistently use string.
masih
force-pushed
the
masih/fix-invalid-sig-get-deals
branch
from
08fe693 to
949a619
Compare
willscott
approved these changes
Sep 7, 2023
|
Included in #221 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigating
Invalid handler function signatureon hitting/api/file/{id}/dealsvia the hand-rolled HTTP Client library. The parameter types across get source file and get source file deals is inconsistent. consistently use string.