Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release binaries using goreleaser #271

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Release binaries using goreleaser #271

merged 2 commits into from
Sep 6, 2023

Conversation

xinaxu
Copy link
Contributor

@xinaxu xinaxu commented Sep 6, 2023

Solves #233

Tested locally with goreleaser release --snapshot --clean

@xinaxu xinaxu requested a review from hannahhoward September 6, 2023 07:33
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.07% ⚠️

Comparison is base (ecc2746) 65.02% compared to head (dfb9d4b) 64.96%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #271      +/-   ##
==========================================
- Coverage   65.02%   64.96%   -0.07%     
==========================================
  Files         137      137              
  Lines        8044     8052       +8     
==========================================
  Hits         5231     5231              
- Misses       2106     2114       +8     
  Partials      707      707              
Files Changed Coverage Δ
cmd/app.go 47.32% <ø> (-2.68%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xinaxu xinaxu requested a review from masih September 6, 2023 17:11
Copy link
Contributor

@masih masih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend adding goreleaser snapshot and config check to PR builds just to catch breakages early.

@xinaxu xinaxu merged commit 23ecab5 into main Sep 6, 2023
@xinaxu xinaxu deleted the xinaxu/gorelease branch September 6, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants