Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes from testing #255

Merged
merged 4 commits into from
Sep 1, 2023
Merged

Conversation

hannahhoward
Copy link
Contributor

various cleanups discovered while attempting to run singularity in devnet with motion

-- setting singularity into a TestNet mode
-- a couple more informative errors
-- allow some parsed byte values to be empty when creating a Schedule (so they just become 0)

various cleanups discovered while attempting to run singularity in devnet with motion
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage: 84.90% and project coverage change: -0.01% ⚠️

Comparison is base (ecfaca2) 64.93% compared to head (953e785) 64.92%.

❗ Current head 953e785 differs from pull request most recent head b6c53e2. Consider uploading reports for the commit b6c53e2 to get more accurate results

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/v0.3.x     #255      +/-   ##
==================================================
- Coverage           64.93%   64.92%   -0.01%     
==================================================
  Files                 137      137              
  Lines                8099     8115      +16     
==================================================
+ Hits                 5259     5269      +10     
- Misses               2124     2128       +4     
- Partials              716      718       +2     
Files Changed Coverage Δ
docs/swagger/docs.go 100.00% <ø> (ø)
handler/wallet/import.go 58.62% <0.00%> (ø)
model/replication.go 40.00% <ø> (ø)
service/dealpusher/dealpusher.go 74.35% <25.00%> (-0.65%) ⬇️
cmd/app.go 50.00% <50.00%> (ø)
handler/deal/schedule/create.go 85.58% <100.00%> (+0.97%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Goals

Allow cron schedules to keep running when they run out of deals

# Implementation

- add attribute to the model
- add ability to set attribute on CreateSchedule 
- when jobs run out of deals, if they are cron and set to perpetual,
they don't get marked complete
@hannahhoward hannahhoward merged commit fd11e6d into release/v0.3.x Sep 1, 2023
@hannahhoward hannahhoward deleted the fix/cleanups-from-testing branch September 1, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant