Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Separate the deal check timestamp from UpdatedAt field #346

Closed
masih opened this issue Sep 22, 2023 · 0 comments · Fixed by #384
Closed

[Feature Request]: Separate the deal check timestamp from UpdatedAt field #346

masih opened this issue Sep 22, 2023 · 0 comments · Fixed by #384
Assignees
@xinaxu
Labels
feature Features

Comments

@masih
Copy link
Contributor

masih commented Sep 22, 2023

What is the problem you're trying to solve?

The UpdatedAt field is a timestamp that is implicitly updated by GORM whenever a database entity is updated. This field is present in Deal entity, and gets updated whenever the deal state changes.

For the purposes of Motion integration we need to display a LastVerified field to the user. That timestamp should display the latest timestamp at which the deal integrity was verified as defined by Singularity. This is not necessarily the same timestamp at which the deal record in signularity database was updated.

Describe the workaround you currently have

Using the UpdatedAt timestamp.

Describe the feature you'd like

A separate timestamp in Deal entity that is updated by deal tracker Which exclusively corresponds to the latest timestamp at which the deal integrity was checked.

Additional context

See:
@masih masih added feature request Feature Request triage labels Sep 22, 2023
@xinaxu xinaxu removed the triage label Oct 4, 2023
@github-project-automation github-project-automation bot moved this to 🍇 Backlog in ActionArena Oct 4, 2023
@xinaxu xinaxu added feature Features and removed feature request Feature Request labels Oct 4, 2023
This was referenced Oct 12, 2023
Merged
Closed
@xinaxu xinaxu closed this as completed Oct 18, 2023
@github-project-automation github-project-automation bot moved this from 🍇 Backlog to 🚢 Done in ActionArena Oct 18, 2023
xinaxu added a commit that referenced this issue Oct 19, 2023
@xinaxu
Add LastVerifiedAt to deal model (#384)
2775d73 
resolves #346 

This adds a new field `last_verified_at` to the `deals` table. Currently
the value is set to the epoch when the deal tracker updates the deal
status to `active`.

In later iterations, we may change it to when POST message lands on
chain.

Follow-up on motion side:
- filecoin-project/motion#162
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xinaxu xinaxu

Labels
feature Features
Projects
ActionArena
Status: 🚢 Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add LastVerifiedAt to deal model data-preservation-programs/singularity
2 participants
@masih @xinaxu