[Bug]: Deals marked as proposal_expired and then published

[xinaxu]

Description

I got some weird behavior with deal-tracker
Deal state changed {"dealID": xxx, "oldState": "proposal_expired", "newState": "published"}
marked 3 deal as proposal_expired
updated 3 deals and inserted 0 deals
How could a deal move from expired to published?
Happens each round, with the same message, so guess no real update is being done

Steps to Reproduce

A couple IDs I have at the moment:
2023-09-20T09:32:43.957+0200 INFO dealtracker dealtracker/dealtracker.go:468 Deal state changed {"dealID": 54464983, "oldState": "proposal_expired", "newState": "published"}
2023-09-20T09:32:44.307+0200 INFO dealtracker dealtracker/dealtracker.go:468 Deal state changed {"dealID": 54486432, "oldState": "proposal_expired", "newState": "published"}

Version

singularity v0.4.1-a1977e5

Operating System

Linux

Database Backend

SQLite

Additional context

No response

[xinaxu]

The root cause identified. When determing new state, there is 1 day of buffer time to consider when the deal proposal has expired to take into account the potential latency of lotus API / state market deals. After updating the state, the deal is updated back to expiration based on the actual delay of lotus API. Those two time mismatched, causing the deal to be updated back and force between expired and published within that 24 hours window