Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add coordinate disambiguation with cf_xarray #83

Merged
merged 6 commits into from
May 21, 2024

Conversation

chrishavlin
Copy link
Collaborator

@chrishavlin chrishavlin commented Apr 3, 2024

This adds an optional dependency, cf_xarray, in order to help with coordinate disambiguation. When cf_xarray is installed, the conversion from xarray coordinate name to yt coordinate name will also check cf standard names for the selected fields.

still to do:

  • update docs

Closes #48

@chrishavlin chrishavlin added the enhancement New feature or request label Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.82%. Comparing base (6d87e82) to head (db3c9dc).
Report is 18 commits behind head on main.

Current head db3c9dc differs from pull request most recent head f099d79

Please upload reports for the commit f099d79 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
- Coverage   98.95%   98.82%   -0.14%     
==========================================
  Files          20       15       -5     
  Lines        1922     1273     -649     
==========================================
- Hits         1902     1258     -644     
+ Misses         20       15       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrishavlin
Copy link
Collaborator Author

pre-commit.ci autofix

@chrishavlin chrishavlin added this to the v0.3.0 milestone May 21, 2024
@chrishavlin chrishavlin merged commit e0c80a4 into data-exp-lab:main May 21, 2024
13 checks passed
@chrishavlin chrishavlin deleted the cfxr_coord_disamb branch May 21, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consider using cf-xarray
1 participant