test unhealthy shares #1649
Merged
test unhealthy shares #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrkalos
force-pushed
the
feature/share_tests
branch
from
d1f3c09 to
13c615f
Compare
petrkalos
force-pushed
the
feature/share_tests
branch
from
d3da001 to
85969b3
Compare
SofiaSazonova
requested changes
Oct 22, 2024
| @@ -285,16 +285,16 @@ def persistent_group_share_1( | |||
| def persistent_role_share_1( | |||
| client5, | |||
| client1, | |||
| updated_persistent_env1, | |||
| updated_persistent_cross_acc_env_1, | |||
| persistent_env1, | |||
| db_name = f'dataall_{share.dataset.datasetName}_{share.dataset.datasetUri}_shared'.replace('-', '_') | ||
| lf_client.revoke_db_perms(principal_role.arn, db_name, ['DESCRIBE']) | ||
| # verify all items are `Unhealthy` | ||
| check_verify_share_items(client5, share.shareUri, expected_health_status=['Unhealthy']) |
There was a problem hiding this comment.
Should we add the check of the reasons, why share is Unhealthy? I mean, check, that the status message corresponds the things that is broken?
| reapply_items_share_object(client1, share_uri, item_uris) | ||
| share_object = get_share_object(client1, share_uri) | ||
| assert_that(share_object['items'].nodes).extracting('healthStatus').contains_only('PendingReApply') | ||
| check_share_items_verified(client1, share_uri) |
There was a problem hiding this comment.
After share is reapplied, we need to check, that now it's healthy
There was a problem hiding this comment.
good catch, I meant to do check_verify_share_items
petrkalos
force-pushed
the
feature/share_tests
branch
from
85969b3 to
0a41428
Compare
SofiaSazonova
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
New tests
Imrpovements
Relates
Solves parts of #1376
Security
Please answer the questions below briefly where applicable, or write
N/A. Based onOWASP 10.
fetching data from storage outside the application (e.g. a database, an S3 bucket)?
evalor similar functions are used?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.