Feat/integ tests notifications #1597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlpzx
reviewed
Oct 1, 2024
tests_new/integration_tests/modules/notifications/test_notifications.py
Outdated
Show resolved
Hide resolved
dlpzx
reviewed
Oct 1, 2024
dlpzx
reviewed
Oct 1, 2024
dlpzx
reviewed
Oct 1, 2024
tests_new/integration_tests/modules/notifications/test_notifications.py
Outdated
Show resolved
Hide resolved
dlpzx
reviewed
Oct 3, 2024
Is there another PR for shares that I should wait for on shares before testing once more that all shares tests + notification tests work in tandem? @dlpzx |
petrkalos
reviewed
Dec 5, 2024
Comment on lines
29
to
38
| context = get_context() | ||
| with context.db_engine.scoped_session() as session: | ||
| notification = session.query(models.Notification).get(uri) | ||
| if notification and (notification.recipient in context.groups + [context.username]): | ||
| return f(*args, **kwds) | ||
| else: | ||
| raise exceptions.UnauthorizedOperation( | ||
| action='UPDATE NOTIFICATION', | ||
| message=f'User {context.username} is not the recipient user/group of the notification {uri}', | ||
| ) |
There was a problem hiding this comment.
Would you mind moving the check logic in a standalone static method so that we are able to mock/spy it from the tests? See here can_perform is the decorator and is_owner the implementation.
The reason we cannot mock it like that is that decorators are applied at module load time and we patch much later.
So to workaround it we would have to patch before we import the modules which works but is very strange.
petrkalos
requested changes
Dec 5, 2024
petrkalos
approved these changes
Dec 9, 2024
dlpzx
reviewed
Dec 10, 2024
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| def _session(): |
There was a problem hiding this comment.
I think _session is no longer used
dlpzx
approved these changes
Dec 10, 2024
dlpzx
pushed a commit
that referenced
this pull request
Dec 24, 2024
### Feature or Bugfix <!-- please choose --> - Bugfix ### Detail - Change path to `global_conftest` for shares integ tests ### Relates - #1597 ### Security Please answer the questions below briefly where applicable, or write `N/A`. Based on [OWASP 10](https://owasp.org/Top10/en/). - Does this PR introduce or modify any input fields or queries - this includes fetching data from storage outside the application (e.g. a database, an S3 bucket)? - Is the input sanitized? - What precautions are you taking before deserializing the data you consume? - Is injection prevented by parametrizing queries? - Have you ensured no `eval` or similar functions are used? - Does this PR introduce any functionality or component that requires authorization? - How have you ensured it respects the existing AuthN/AuthZ mechanisms? - Are you logging failed auth attempts? - Are you using or adding any cryptographic features? - Do you use a standard proven implementations? - Are the used keys controlled by the customer? Where are they stored? - Are you introducing any new policies/roles/users? - Have you used the least-privilege principle? How? By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
dlpzx
added a commit
that referenced
this pull request
Dec 26, 2024
### Feature or Bugfix <!-- please choose --> - Feature ### Detail - Integration Tests Notifications ### Relates - #1220 ### Security Please answer the questions below briefly where applicable, or write `N/A`. Based on [OWASP 10](https://owasp.org/Top10/en/). - Does this PR introduce or modify any input fields or queries - this includes fetching data from storage outside the application (e.g. a database, an S3 bucket)? - Is the input sanitized? - What precautions are you taking before deserializing the data you consume? - Is injection prevented by parametrizing queries? - Have you ensured no `eval` or similar functions are used? - Does this PR introduce any functionality or component that requires authorization? - How have you ensured it respects the existing AuthN/AuthZ mechanisms? - Are you logging failed auth attempts? - Are you using or adding any cryptographic features? - Do you use a standard proven implementations? - Are the used keys controlled by the customer? Where are they stored? - Are you introducing any new policies/roles/users? - Have you used the least-privilege principle? How? By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Sofia Sazonova <[email protected]> Co-authored-by: dlpzx <[email protected]>
dlpzx
pushed a commit
that referenced
this pull request
Dec 26, 2024
### Feature or Bugfix <!-- please choose --> - Bugfix ### Detail - Change path to `global_conftest` for shares integ tests ### Relates - #1597 ### Security Please answer the questions below briefly where applicable, or write `N/A`. Based on [OWASP 10](https://owasp.org/Top10/en/). - Does this PR introduce or modify any input fields or queries - this includes fetching data from storage outside the application (e.g. a database, an S3 bucket)? - Is the input sanitized? - What precautions are you taking before deserializing the data you consume? - Is injection prevented by parametrizing queries? - Have you ensured no `eval` or similar functions are used? - Does this PR introduce any functionality or component that requires authorization? - How have you ensured it respects the existing AuthN/AuthZ mechanisms? - Are you logging failed auth attempts? - Are you using or adding any cryptographic features? - Do you use a standard proven implementations? - Are the used keys controlled by the customer? Where are they stored? - Are you introducing any new policies/roles/users? - Have you used the least-privilege principle? How? By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
Relates
Security
Please answer the questions below briefly where applicable, or write
N/A. Based onOWASP 10.
fetching data from storage outside the application (e.g. a database, an S3 bucket)?
evalor similar functions are used?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.