Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests feed #1579

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Add integration tests feed #1579

merged 3 commits into from
Oct 1, 2024

Conversation

noah-paige
Copy link
Contributor

Feature or Bugfix

  • Feature

Detail

  • Add integration tests for feed module

Relates

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

  • Does this PR introduce or modify any input fields or queries - this includes
    fetching data from storage outside the application (e.g. a database, an S3 bucket)?
    • Is the input sanitized?
    • What precautions are you taking before deserializing the data you consume?
    • Is injection prevented by parametrizing queries?
    • Have you ensured no eval or similar functions are used?
  • Does this PR introduce any functionality or component that requires authorization?
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
    • Are you logging failed auth attempts?
  • Are you using or adding any cryptographic features?
    • Do you use a standard proven implementations?
    • Are the used keys controlled by the customer? Where are they stored?
  • Are you introducing any new policies/roles/users?
    • Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@SofiaSazonova SofiaSazonova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, that it's not the most interesting part of data.all, but... Don't we need to test non-happy path like 'no permissions to post feed' or smth?

@noah-paige
Copy link
Contributor Author

I know, that it's not the most interesting part of data.all, but... Don't we need to test non-happy path like 'no permissions to post feed' or smth?

Currently we do not protect against postFeedMessage or getFeed - meaning any data.all users can execute those APIs

I can add an additional check to ensure error thrown when targetUri and targetType not specified at a bare minimum at this point to add some coverage

But overall may want to make feed more robust and add some additional checks at a later date

@noah-paige
Copy link
Contributor Author

@SofiaSazonova - pushed some unhappy path checks, please re-review when you have some time!

@noah-paige noah-paige self-assigned this Sep 30, 2024
@noah-paige noah-paige merged commit cb909e9 into main Oct 1, 2024
9 checks passed
@noah-paige noah-paige deleted the feat/integ-tests-feed branch October 1, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants