-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Glossaries integration tests #1556
Conversation
c445e8f
to
9bdb228
Compare
9bdb228
to
6b31533
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments - mostly suggested additions but overall it looks good, will give a test and wait to hear your thoughts on the comments
|
||
def test_start_reindex_catalog_handle_deletes(clientTenant): | ||
response = start_reindex_catalog(clientTenant, handle_deletes=True) | ||
assert_that(response).is_true() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as a future enhancement (not this PR) may want a way to poll the ecs task to ensure it completes and then a way to ensure catalog populated appropriately
but out of scope for this PR imo
Can we also add to #1557 to separate out glossary from catalog - do not think they should be the same module |
5cef31d
to
22a583c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good and tested -approving!
Feature or Bugfix
Detail
Implement tests for Glossaries/Catalog as part of #1220
During the implementation several enhancement ideas came up and are collected in #1557
Tested in local with connection to real AWS deployment:
Relates
Security
Please answer the questions below briefly where applicable, or write
N/A
. Based onOWASP 10.
fetching data from storage outside the application (e.g. a database, an S3 bucket)?
eval
or similar functions are used?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.