Generic shares_base module and specific s3_datasets_shares module - part 8 (share_item_service)

[dlpzx]

Feature or Bugfix

• Refactoring

Detail

As explained in the design for #1123 and #1283 we are trying to implement generic datasets_base and shares_base modules that can be used by any type of datasets and by any type of shareable object in a generic way.

The goal of this PR is to split the share_item_servicelogic into the a generic service in shares_base and an specific service in s3_datasets_shares.

• ShareItemService in shares_base only has shareItem logic without references to S3 or Glue.
• S3ShareItemService in s3_datasets_shares has logic for share items that are tables and folders.

The files' names are a bit messy but i don't want to pollute this PR with more changes. I'll do a review of the file names in part 10.

Relates

• Create generic shares_base and s3_datasets_shares modules from current dataset_sharing #1283
• Create generic dataset_base and s3_dataset modules from current datasets #1123
• Redshift Data Sharing #955

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

• Does this PR introduce or modify any input fields or queries - this includes
  fetching data from storage outside the application (e.g. a database, an S3 bucket)?
  • Is the input sanitized?
  • What precautions are you taking before deserializing the data you consume?
  • Is injection prevented by parametrizing queries?
  • Have you ensured no eval or similar functions are used?
• Does this PR introduce any functionality or component that requires authorization?
  • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
  • Are you logging failed auth attempts?
• Are you using or adding any cryptographic features?
  • Do you use a standard proven implementations?
  • Are the used keys controlled by the customer? Where are they stored?
• Are you introducing any new policies/roles/users?
  • Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[dlpzx]

I tested locally that everything loads as usual , that the ShareItemService is reachable (by clicking in verify items) and that the S3ShareItemService is used in the sharing (by revoking a folder, the delete_permissions is called)