Fix s3_datasets and s3_datasets_shares tests #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noah-paige
reviewed
Jun 11, 2024
There was a problem hiding this comment.
I see in conftest there is def share_item_folder which includes defining ShareObjectItem(...) with parameter S3AccessPointName which no longer exists
This fixture is not used anywhere in the tests and all tests pass but I imagine this is part of the improvements to conftests to come later
noah-paige
reviewed
Jun 11, 2024
| @@ -192,6 +192,7 @@ def check_target_role_access_policy(self) -> None: | |||
| version_id, policy_document = IAM.get_managed_policy_default_version( | |||
| self.target_environment.AwsAccountId, self.target_environment.region, share_resource_policy_name | |||
| ) | |||
| logger.info(f'Policy... {policy_document}') | |||
There was a problem hiding this comment.
nit: is this leftover form debugging or want to keep for logging?
noah-paige
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
With the refactoring of the datasets and the datasets_sharing tests were not being executed. In this PR the corresponding tests packages are renamed and the tests inside are fixed with the latest changes in main.
There are still things to improve, for example we can simplify the conftests of the s3_datasets and the s3_datasets_shars modules; but I am going to leave it for a next PR
Relates
Security
Please answer the questions below briefly where applicable, or write
N/A. Based onOWASP 10.
fetching data from storage outside the application (e.g. a database, an S3 bucket)?
evalor similar functions are used?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.