Enhancements related to UI for the share verify and re-apply feature #1107
Assignees
Labels
Comments
|
Hi @anushka-singh thank you for opening an issue. It is perfectly explained and some of the things are quick wins. We will add this item to 2.5 (UX improvements) project and address as many items as possible |
dlpzx
added
type: enhancement
noah-paige
added a commit
that referenced
this issue
Jun 25, 2024
### Feature or Bugfix <!-- please choose --> - Feature ### Detail - Enhance Share UI for re-apply and verify share health status ### Relates - #1107 ### Security Please answer the questions below briefly where applicable, or write `N/A`. Based on [OWASP 10](https://owasp.org/Top10/en/). - Does this PR introduce or modify any input fields or queries - this includes fetching data from storage outside the application (e.g. a database, an S3 bucket)? - Is the input sanitized? - What precautions are you taking before deserializing the data you consume? - Is injection prevented by parametrizing queries? - Have you ensured no `eval` or similar functions are used? - Does this PR introduce any functionality or component that requires authorization? - How have you ensured it respects the existing AuthN/AuthZ mechanisms? - Are you logging failed auth attempts? - Are you using or adding any cryptographic features? - Do you use a standard proven implementations? - Are the used keys controlled by the customer? Where are they stored? - Are you introducing any new policies/roles/users? - Have you used the least-privilege principle? How? By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
|
Completed in #1346 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your idea related to a problem? Please describe.
In my testing for feature: https://github.com/data-dot-all/dataall/pull/1062/files I found some enhancements that can be made to the frontend. We can do this as a part of 2.4 if we so choose. They are really minor changes but would lead to overall better user experience.
Healthyin the screenshot belowBug: After clicking on verify status button, the page does not auto-refresh with updated status and timestamp. I need to hit refresh on the page every-time to get an updated status.
When revoke succeeded, health status states
Undefinedinstead ofNoneor something a little more meaningful. Also, the...is a little misleading because as a user, I keep waiting for it to change. We can also remove status altogether and replace with a dash-. That might be more meaningful.While a share item is in 'PendingReApply'. I still have the option to revoke the item. I think we should block off that option when share is being fixed, to avoid inconsistency.
When I hit verify on the overall dataset, there is a pop-up saying verify has started. After that, as a user I would be confused as there is no UI update on this page.
Only if I open the share request, do I see that verification is in progress. There is no status update here at all. I am not notified that verification is complete. We could have a UI pop-up redirecting users to the individual share request pages to track the status of the health check and to re-apply shares if anything is broken. We could also have a button here to re-apply shares to all failed verification checks.
P.S. Don't attach files. Please, prefer add code snippets directly in the message body.
The text was updated successfully, but these errors were encountered: