Ensure that Jax float0 array is recognized #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is intended to be a temporary solution until Jax (ideally) makes these arrays into Jax arrays. I don't see any reasonable way for clients to work around this unless this is fixed on the library side. |
|
(Error appears to be unrelated to this pull request.) |
|
This looks good. Can you add a test. |
|
Great, I added a test. |
asmeurer
reviewed
Apr 15, 2024
asmeurer
reviewed
Apr 15, 2024
asmeurer
reviewed
Apr 15, 2024
|
The tests failure should be fixed by my suggestion, and the test suite failure should be fixed by #131. |
|
(Done.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See jax-ml/jax#20620.