This repository has been archived by the owner on Jan 6, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 69
Buttonify #282
Merged
Merged
Buttonify #282
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
af3a7e8
implement button component
yoshuawuyts f1aec20
fixup! add newButton
yoshuawuyts 2c741d8
add newIcon, newButton pkgs
yoshuawuyts 4aae8d2
update icon
yoshuawuyts 860e219
fixup! more progress
yoshuawuyts 1e698d8
fixup! migrate main.js
yoshuawuyts 91b419d
fixup! all aboard the button train
yoshuawuyts 2bc9a9e
fixup! move icons over
yoshuawuyts 25e9184
fixup! restore file names
yoshuawuyts e638cc4
fixup! fix tests
yoshuawuyts 896be75
fixup! fix missing buttons
yoshuawuyts e7cc70b
fix final button styles
yoshuawuyts 743bcb2
fix alignment of network icon
Kriesse dc10998
fix alignment of checkmark icon in copy link modal
Kriesse 6d6f0d3
remove color variables from default icon styles
Kriesse 37f8e6a
fix size and alignment of intro screen svgs
Kriesse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about this syntax?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I kinda like that; very close to hyperscript's class / id shorthand - I think having that at some point would definitely make sense. Nice ✨
I'd probably make sure there'd be full consistency with hyperscript tho:
but yeah that's nit picking. I like it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like having the 'class' dict, it also is just as simple and already works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
annnnd... package! - https://github.com/yoshuawuyts/parse-class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah nah, agree - this would only work for icons right now; buttons is harder - gonna leave this for a bit