Ensure ConnectionPool closes even if network stack swallows cancellation #8928
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we've seen some workers not closing properly in cases where the scheduler died very unusual deaths. We saw that workers, particularly Nannies, wouldn't close for whatever reason without any sound.
For this section in the code it is at least in theory possible to lock up in case the connector (in this case tornado which I generally trust to do these things properly) swallows cancellation attempts completely.
I don't have confidence that this is actually related but in case I'm missing something, let's remove that edge case.