Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dask-expr to dask conda recipe #8601

Merged
merged 4 commits into from
Apr 2, 2024

Conversation

charlesbluca
Copy link
Member

Closes #8574
Supersedes #8575

  • Tests added / passed
  • Passes pre-commit run --all-files

@charlesbluca charlesbluca requested a review from fjetter as a code owner March 26, 2024 14:56
Copy link
Contributor

github-actions bot commented Mar 26, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    29 files  ± 0      29 suites  ±0   11h 9m 10s ⏱️ + 9m 57s
 4 058 tests ± 0   3 947 ✅  -  2    109 💤 ±0  2 ❌ +2 
54 930 runs  +18  52 521 ✅ +21  2 407 💤  - 5  2 ❌ +2 

For more details on these failures, see this check.

Results for commit b9793d2. ± Comparison against base commit 3f77d1b.

♻️ This comment has been updated with latest results.

@rjzamora
Copy link
Member

@charlesbluca - Just checking in: Is this blocked by any legitimate CI failures?

@charlesbluca
Copy link
Member Author

Nope, think this is all just flaky CI - the core job impacted here is the conda build which should be unblocked by this

@quasiben
Copy link
Member

quasiben commented Apr 1, 2024

Thanks @charlesbluca @rjzamora . As this changes conda yml we should give @jrbourbeau and/or @fjetter some time to review. I'll tentatively plan to merge after the release of 2024.4.1
xref: dask/community#370

@quasiben
Copy link
Member

quasiben commented Apr 2, 2024

With the release done and dask/dask#11014 merged in. I'll merge this when CI finishes. Looking green so far...

@quasiben
Copy link
Member

quasiben commented Apr 2, 2024

I think we can ignore the codecov failure here as this PR touches no code. We suspect this is an issue with uploaded base vs head. Merging in

@quasiben quasiben merged commit 5647d06 into dask:main Apr 2, 2024
34 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conda Build CI needs to be updated for dask-expr
3 participants