Revert pickle change #8456
Merged
Revert pickle change #8456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendrikmakait
approved these changes
Jan 12, 2024
|
|
||
|
|
||
| @pytest.mark.slow() | ||
| def test_pickle_functions_in_main(tmp_path): |
I hate windows |
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 27 files ± 0 27 suites ±0 9h 40m 22s ⏱️ + 10m 35s For more details on these failures, see this check. Results for commit 30b0030. ± Comparison against base commit 9fb41e3. |
|
Thanks @fjetter and @hendrikmakait ! |
vyasr
added a commit
to rapidsai/rapids-dask-dependency
that referenced
this pull request
Jan 12, 2024
This reverts commit 4a2dd6f. The upstream distributed bug was fixed in dask/distributed#8456.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pickle implementation is odd (see #8455) so I chose to revert #8443 to close #8454 instead of trying to fix it.
This should be revisited. The current logic is pretty awful since it can trigger serialization up to three times until it reaches success. For very large graphs this can be a problem.
I'm not sure what best to do here in the long run but considering this is not a major problem right now, I'm inclined to postpone this decision until later.