Reduce memory usage during culling for shuffling and merge #8197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjetter
approved these changes
Sep 20, 2023
fjetter
reviewed
Sep 20, 2023
| parts_out = parts_out or self._keys_to_parts(keys) | ||
| keys = {(self.name_input_left, i) for i in range(self.npartitions)} | ||
| keys |= {(self.name_input_right, i) for i in range(self.npartitions)} | ||
| keys = frozenset(keys) |
There was a problem hiding this comment.
maybe add a comment why this is a frozenset. Using a frozenset is a bit uncommon and if we're honest this is just paranoia / testing
Co-authored-by: Florian Jetter <[email protected]>
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 21 files ± 0 21 suites ±0 9h 40m 1s ⏱️ - 1h 19m 13s For more details on these failures, see this check. Results for commit e4cd8f9. ± Comparison against base commit 1650ceb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8196
pre-commit run --all-filesNot sure if we can add tests here that would actually help. memory spike is gone on this branch