Use properly imported MatDescriptor for cupy dispatch registration
#7868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rerun tests |
|
Looks like the initial UCX failures were unrelated? Unable to reproduce locally |
|
Probably #5229 (known flaky test) |
jrbourbeau
changed the title
MatDescriptor for cupy dispatch registrationMatDescriptor for cupy dispatch registration
|
Thanks Charles & James! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like we missed one remaining appearance of
cusparsein CuPy's dispatch registration, which was relocated incupy=12.Noting that from #7836 (comment) this code seems to be a workaround for an issue in
cupy<8?So we may be able to remove this in the near future; for now this should unblock GPU CI
cc @jrbourbeau @wence-
Closes #7866
xref: rapidsai/dask-cuda#1174
pre-commit run --all-files