Log popen stdout/err when subprocess times out #6567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ± 0 15 suites ±0 6h 31m 51s ⏱️ + 2m 23s Results for commit 9309c4f. ± Comparison against base commit 058e629. ♻️ This comment has been updated with latest results. |
|
Doesn't seem to work on windows |
|
Yeah. I think that makes sense because Windows doesn't have SIGINT vs SIGKILL. |
pytest will suppress it if the test passes
Printing the logs will likely help diagnose why this test is hanging.
This is a shot in the dark
* different exit code on windows (not -9) * `/bin/echo` obvs doesn't exist
|
Wooo it's green! Ready to merge @fjetter @crusaderky. |
fjetter
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress towards #6395. This should give us visibility into what's happening when the subprocess times out.
cc @crusaderky @mrocklin
pre-commit run --all-files