Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core.write coroutine waits on IOStream.write futures. However, there are
some cases where IOStream.write futures don't complete. Notably if something
else writes to the same stream before we're done waiting then the first future
is forgotten and hangs forever.
This solution wraps the wait in a timeout and checks the stream's
write_buffer as a secondary check for completion. There are probably better
solutions that don't rely on the timeout but this should work fine.
cc @pitrou