Move wait_for_signals to private module and deprecate distributed.cli.utils
#6367
Conversation
hendrikmakait
changed the title
wait_for_signals and deprecate distributed.cli.utilswait_for_signals to private module and deprecate distributed.cli.utils
| from tornado.ioloop import IOLoop | ||
|
|
||
| warnings.warn( | ||
| "the distributed.cli.utils module is deprecated", DeprecationWarning, stacklevel=2 |
There was a problem hiding this comment.
Perhaps this warning could point folks to an issue or some advice on migration. Both of the functions available in this package are no longer going to be available outside distributed. So projects that depend on them will need to some something else.
There was a problem hiding this comment.
Also shouldn't this be calling from distributed._signals import wait_for_signals to avoid breakages?
There was a problem hiding this comment.
There should be no current dependencies apart from dask_scheduler.py and dask_worker.py unless someone has been very fast in following up with this change. I would not import wait_for_signals in distributed.cli.utils to keep it private.
Regarding the advice on migration: I'll try to come up with something, maybe @graingert has some good ideas?
There was a problem hiding this comment.
Ah right I see it's a new method! That makes sense.
Follow-up to #6366
pre-commit run --all-files