Fix test_ucx_unreachable on UCX < 1.12
#5562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pentschev
changed the title
test_ucx_unreachable on UCX < 1.12
|
It seems that #5560 still didn't resolve everything. This one should hopefully do it. Sorry @jrbourbeau for all the back and forth with this. cc @quasiben |
|
There's only a windows failure here which is unrelated to the PR and it looks like gpuCI is now passing. Thanks @pentschev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test_ucx_unreachableissue for UCX >= 1.12 was fixed by #5560, but in UCX 1.11 we need a different check which is addressed here.