Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Remove pytest asyncio pinning #4858

Closed
wants to merge 2 commits into from

Conversation

fjetter
Copy link
Member

@fjetter fjetter commented May 27, 2021

This removes the pinning for pytest-asyncio

Nice side benefit is that we'll wrap all asyncio marked tests automagically with our clean ctx manager.

@fjetter fjetter changed the title WIP Relieve pytest asyncio pinning WIP Remove pytest asyncio pinning May 27, 2021
@QuLogic
Copy link
Contributor

QuLogic commented Mar 6, 2022

Is there some possibility of moving this forward soon?

@fjetter
Copy link
Member Author

fjetter commented Mar 7, 2022

Is there some possibility of moving this forward soon?

It's unlikely that I'll find time for this soon. If you are up for it, feel free to have a look

@graingert
Copy link
Member

might be better to use @gen_test instead of @pytest.mark.asyncio and drop the dep on pytest-asyncio

@fjetter
Copy link
Member Author

fjetter commented Mar 7, 2022

might be better to use @gen_test instead of @pytest.mark.asyncio and drop the dep on pytest-asyncio

I'm open for this as well. In the past, usage of pytest-asyncio was useful because we could more easily use pytest fixtures. gen_test does support this by now so I don't see a strong reason for a continued usage of pytest-asyncio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants