Add descriptions for UCX config options #4683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @quasiben if you get a moment to look at the descriptions here |
|
Also cc @pentschev who has done a lot of the UCX docs |
pentschev
approved these changes
Apr 7, 2021
There was a problem hiding this comment.
A few minor suggestions, but otherwise LGTM. Thanks @charlesbluca !
Co-authored-by: Peter Andreas Entschev <[email protected]>
|
Check failure is due to a timeout - not sure why it happened, but don't think it's related to these changes |
jacobtomlinson
approved these changes
Apr 20, 2021
|
I just merged |
|
Lots of failures around |
|
Ah, yeah sorry about that -- it's being resolved over in #4719 |
jrbourbeau
approved these changes
Apr 20, 2021
This was referenced Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds descriptions for the UCX options in the Dask configuration reference, as part of efforts to simplify the Dask-CUDA documentation.
It also changes the default values of several of these options from
nulltoFalse, as I feel that makes it more explicitly clear that these options are disabled by default (and I don't think this change should have any impact on the behavior of Distributed).black distributed/flake8 distributed/isort distributed