Fix un-merged frames #4666
Merged
Fix un-merged frames #4666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we would re-serialize an object, even if it was a Serialized object. Instead we should just unpack its header and frames and be done.
|
OK, I think that we might be ok here |
|
Awesome thanks for figuring this out Matt 😄 |
jakirkham
approved these changes
Apr 2, 2021
douglasdavis
pushed a commit
to douglasdavis/distributed
that referenced
this pull request
Apr 2, 2021
* Add test for un-merged frames * Don't double-split/compress Serialized frames Previously we would re-serialize an object, even if it was a Serialized object. Instead we should just unpack its header and frames and be done. * specify num_sub_frames in all cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far this is only a test. (thanks @jakirkham )
_pickle.UnpicklingError: pickle data was truncatedfor multiple parquet files #4662