Treat empty/missing writeable as a no-op
#4659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `writeable` filled with `None` will not equal `True` or `False`, this will effectively be treated as a no-op along frames to be pushed into `new` without copying. Should fix some issues that users are running into around serialization of data.
|
Went ahead and merged so we can get this fix into the bug fix release this Friday. Happy to follow up on anything else in subsequent issues and PRs as needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
writeablefilled withNonewill not equalTrueorFalse, this will effectively be treated as a no-op along frames to be pushed intonewwithout copying.Should fix some issues that users are running into around serialization of data.
distributed.protocol.serialize.pickle_loadsfails withIndexError: tuple index out of range#4645black distributed/flake8 distributed/isort distributed