-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default branch from master to main #4495
Conversation
Just a note, we might want to add |
Thanks @jakirkham. I just tried pip installing from git without specifying the branch and it seemed to work fine. conda create -n test pip python=3.7
conda activate test
pip install git+https://github.com/dask/zict.git |
Interesting. Well here is the CI failure we saw |
Maybe a non-zero exit code is being set (even though it happens to work)? |
Definitely the windows part of #4499 replacing master with main needed to happen. I am just wondering if the travis part did. |
Right was wondering if that happened when running locally |
I just rebased and I expect this to pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jsignell. Given the recent release, and no reported issues with the branch name change in other dask/*
repos, I think we're in a good place to merge this (and the corresponding PR in dask/dask
) soon. I'll comment over in the community issue just to give people a heads up
I think the failure is unrelated, so this should be good to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jsignell!
What's the ETA on fixing the Dask branch as well? We need to update some CI environments and would ideally like to make this change once Edit: Following up in PR ( dask/dask#7198 (comment) ) |
I'm realizing that doing distributed and dask at the same time is unfeasible since it'll mean that the tests never pass. I am going to split this up into just the distributed part.