-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow pickle protocol to be overridden #4012
Conversation
Provide users the option to override `protocol` in our `dumps` function. If it is not specified, default to the `HIGHEST_PROTOCOL` just as before.
pickle: | ||
protocol: null # specify the pickle protocol to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just placed this at the global level as it is not really worker or scheduler specific. Not picky on where it lives though.
Interesting. I'm curious, what was the motivation? |
Issue ( #4011 ) encouraged me to put it in a PR. Albeit that issue is discussing a different solution. Could also be useful for debugging/helping users. |
Thanks for the speedy response to that issue. If we were to go this approach (which seems sensible regardless) I would then ask the question what should we make the default? 4 or 5? I suspect that your answer is likely "5, because it's faster" while I probably tend towards "4, because it's robust". I'm curious, did we ever speed test pickle protocol 5 on a real-world workload? Would something like |
Closing since this seems to be addressed by PR ( #4019 ). |
Woot. Thanks for the early effort @jakirkham |
This provides the option to override the pickle protocol used. The default behavior is still to use the
HIGHEST_PROTOCOL
. However this provides users an easy way to customize the pickle protocol through thedistributed.yaml
config.cc @mrocklin @quasiben