Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart worker via Nanny on connection failure #6387

Open
Tracked by #6384
gjoseph92 opened this issue May 20, 2022 · 1 comment
Open
Tracked by #6384

Restart worker via Nanny on connection failure #6387

gjoseph92 opened this issue May 20, 2022 · 1 comment
Labels
enhancement Improve existing functionality or make things work better hygiene Improve code quality and reduce maintenance overhead

Comments

@gjoseph92
Copy link
Collaborator

With #6361, any temporary network disconnect will shut down the worker.

If we have a Nanny around, we could at least let the Nanny restart the worker, so it can try to reconnect from a fresh state. Currently, we tell the Nanny to close gracefully.

There are a couple of things to think about:

gjoseph92 added a commit to gjoseph92/distributed that referenced this issue May 23, 2022
This isn't necessary, we could leave it. But I find `terminate` vs `close` confusingly-named, and it's not really going to be used now. I think this might be better added as part of dask#6387? Could go either way.
@fjetter fjetter added enhancement Improve existing functionality or make things work better hygiene Improve code quality and reduce maintenance overhead labels May 25, 2022
gjoseph92 added a commit to gjoseph92/distributed that referenced this issue Jun 3, 2022
@crusaderky crusaderky self-assigned this Nov 21, 2022
@fjetter
Copy link
Member

fjetter commented Nov 25, 2022

I think this is blocked by #7323

@crusaderky crusaderky removed their assignment Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality or make things work better hygiene Improve code quality and reduce maintenance overhead
Projects
None yet
Development

No branches or pull requests

3 participants