Skip to content

Commit

Permalink
Remove unused delete_interval and synchronize_worker_interval fro…
Browse files Browse the repository at this point in the history
…m `Scheduler` (#8801)
  • Loading branch information
hendrikmakait authored Jul 30, 2024
1 parent 5e1d365 commit 40fcd65
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 25 deletions.
6 changes: 0 additions & 6 deletions distributed/scheduler.py
Original file line number Diff line number Diff line change
Expand Up @@ -3606,8 +3606,6 @@ class Scheduler(SchedulerState, ServerNode):
def __init__(
self,
loop=None,
delete_interval="500ms",
synchronize_worker_interval="60s",
services=None,
service_kwargs=None,
allowed_failures=None,
Expand Down Expand Up @@ -3656,10 +3654,6 @@ def __init__(
if validate is None:
validate = dask.config.get("distributed.scheduler.validate")
self.proc = psutil.Process()
self.delete_interval = parse_timedelta(delete_interval, default="ms")
self.synchronize_worker_interval = parse_timedelta(
synchronize_worker_interval, default="ms"
)
self.service_specs = services or {}
self.service_kwargs = service_kwargs or {}
self.services = {}
Expand Down
19 changes: 0 additions & 19 deletions distributed/tests/test_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -2660,25 +2660,6 @@ async def test_futures_of_cancelled_raises(c, s, a, b):
await c.gather(c.map(add, [1], y=x))


@pytest.mark.skip
@gen_cluster(nthreads=[("127.0.0.1", 1)], client=True)
async def test_dont_delete_recomputed_results(c, s, w):
x = c.submit(inc, 1) # compute first time
await wait([x])
x.__del__() # trigger garbage collection
await asyncio.sleep(0)
xx = c.submit(inc, 1) # compute second time

start = time()
while xx.key not in w.data: # data shows up
await asyncio.sleep(0.01)
assert time() < start + 1

while time() < start + (s.delete_interval + 100) / 1000: # and stays
assert xx.key in w.data
await asyncio.sleep(0.01)


@pytest.mark.skip(reason="Use fast random selection now")
@gen_cluster(client=True)
async def test_balance_tasks_by_stacks(c, s, a, b):
Expand Down

0 comments on commit 40fcd65

Please sign in to comment.