-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow to update gpuCI #8215
Add workflow to update gpuCI #8215
Conversation
This reverts commit ec180b9.
.github/workflows/update-gpuci.yml
Outdated
version_system: "CalVer" | ||
|
||
- name: Strip git tags from versions | ||
run: echo "RAPIDS_VER=${FULL_RAPIDS_VER::-10}" >> $GITHUB_ENV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an easier way to do this? Essentially the output of the above action will be something like 21.12.00a211004
and we want to strip the tags so that it's just 21.12
. To my knowledge, GHA doesn't let you do string manipulation for env variables, so we can't do something like:
${{ steps.latest_version.outputs.version[:-10] }}
.github/workflows/update-gpuci.yml
Outdated
commit-message: "Update gpuCI `RAPIDS_VER` to `${{ env.RAPIDS_VER }}`" | ||
title: "Update gpuCI `RAPIDS_VER` to `${{ env.RAPIDS_VER }}`" | ||
reviewers: "charlesbluca" | ||
# labels: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any suggestions on labels / reviewers? Would probably make sense to add some maintainers that are members of RAPIDS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably leave off labels for now. For reviewers, I'll suggest dask/gpu
instead of specific individuals. This will ensure folks from RAPIDS are pinged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense, though it looks like we might need to use a non-default GitHub token when opening the PR in order to request review from a team:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @charlesbluca! Having this automatically handled will be nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Sadly the string manipulation step is necessary.
I guess we should get this merged and see how it performs.
Thanks @jacobtomlinson - yeah, I think it makes sense to try the workflow out in this repo for the next release cycle and depending on how that goes, adding an updated (or identical) version of this to Distributed. |
Test failures are unrelated. Merging. |
Adds a workflow similar to dask-docker's Dask updating workflow to update the
RAPIDS_VER
used by gpuCI when a new nightly version of cuDF is available.black dask
/flake8 dask
/isort dask