-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace conda with mamba #7227
Replace conda with mamba #7227
Conversation
.github/workflows/ci-additional.yml
Outdated
@@ -18,7 +18,8 @@ jobs: | |||
- name: Setup Conda Environment | |||
uses: conda-incubator/setup-miniconda@v2 | |||
with: | |||
miniconda-version: "latest" | |||
mamba-version: "*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably useful to have a look at the master of the setup-miniconda
actions and use miniforge-variant: Mambaforge
. This gives you a base environment with mamba pre-installed and conda-forge
as a channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are only yet available on master
, not on v2
. If they also work here well, setup-miniconda
could do a new release to have them available in a stable fashion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(ignore; I was still using @v2
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it works now, thanks
Warning: Unexpected input(s) 'miniforge-variant', 'miniforge-version', 'use-mamba'
There is a mamba-specific bug on MacOS Python 3.6 / numpy 1.15:
I'm parking this PR for now and I'm going to retest it after dropping Python 3.6 |
cc @jakirkham who might find this interesting
…On Wed, Feb 17, 2021 at 8:28 AM crusaderky ***@***.***> wrote:
There is a mamba-specific bug on MacOS Python 3.6 / numpy 1.15:
try:
> import scipy.stats
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> from .stats import *
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> from scipy.spatial.distance import cdist
../../../miniconda3/envs/test-environment/lib/python3.6/site-packages/scipy/stats/stats.py:174:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> from .qhull import *
E ImportError: dlopen(/Users/runner/miniconda3/envs/test-environment/lib/python3.6/site-packages/scipy/spatial/qhull.cpython-36m-darwin.so, 2): Library not loaded: @rpath/libopenblas.dylib
E Referenced from: /Users/runner/miniconda3/envs/test-environment/lib/python3.6/site-packages/scipy/spatial/qhull.cpython-36m-darwin.so
E Reason: image not found
../../../miniconda3/envs/test-environment/lib/python3.6/site-packages/scipy/spatial/__init__.py:98: ImportError
I'm parking this PR for now and I'm going to retest it after dropping
Python 3.6
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#7227 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACKZTFBDTG3I7FBCQ4H6ITS7PHCNANCNFSM4XWJIYUQ>
.
|
Would suggest not using |
Raised this in conda-incubator/setup-miniconda#106 (comment) |
.github/workflows/ci-additional.yml
Outdated
@@ -16,9 +16,11 @@ jobs: | |||
uses: actions/checkout@v2 | |||
|
|||
- name: Setup Conda Environment | |||
uses: conda-incubator/setup-miniconda@v2 | |||
uses: conda-incubator/setup-miniconda@master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want this now, you can pin this to a commit:
uses: conda-incubator/setup-miniconda@master | |
uses: conda-incubator/setup-miniconda@77b16ed746da28724c61e1f1ad23395a4b695ef5 |
and then make a follow up PR when a new version gets tagged.
mamba is broken on numpy 1.15 regardless of Python version; see above. |
I've split out the bump to numpy 1.16 into a separate PR, which is now a dependency of this one: #7383 |
# FIXME https://github.com/mamba-org/mamba/issues/412 | ||
# mamba uninstall --force numpy pandas | ||
conda uninstall --force numpy pandas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xref: mamba-org/mamba#412
@jrbourbeau ready for merge. Weirdly, unlike in dask/distributed I don't need to specify the channels in the workflow. |
@crusaderky cool to see this! Any info on what is broken with mamba / numpy 1.15? is it mamba or broken metadata or numpy? If there is something we can fix in mamba, please let us know! |
@wolfv https://github.com/dask/dask/runs/2101922250
this happens on MacOSX only, and only on mamba. conda list output is linked above. |
Ok, looks like mixing defaults & conda-forge channels. Otherwise, at least using strict-channel priority should help (as recommended by conda-forge). |
@wolfv the exact same environment file works fine with conda. |
Shave 2 minutes off each CI workflow
Blocked by #7383