Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filtering on parquet file containing a struct column #11665

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

rjzamora
Copy link
Member

@rjzamora rjzamora commented Jan 10, 2025

Dask does not support filtering on a PyArrow struct column, but it should support filtering on other columns when a struct column is present. This PR fixes a bug in the way we align field names with field indices when struct columns are present.

Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

     15 files  ± 0       15 suites  ±0   4h 28m 29s ⏱️ - 1m 25s
 17 156 tests + 1   15 961 ✅ + 1   1 195 💤 ±0  0 ❌ ±0 
211 366 runs  +12  194 191 ✅ +15  17 175 💤  - 3  0 ❌ ±0 

Results for commit f09cc81. ± Comparison against base commit 1e6ed84.

@phofl phofl merged commit 70305c2 into dask:main Jan 10, 2025
27 checks passed
@phofl
Copy link
Collaborator

phofl commented Jan 10, 2025

Thanks!

I did not know that we aren't supporting filtering on struct columns, do you know if we pay attention not to push filters into read_parquet if they are applied to a struct column?

@rjzamora rjzamora deleted the fix-struct-statistics branch January 10, 2025 20:02
@rjzamora
Copy link
Member Author

I did not know that we aren't supporting filtering on struct columns

Yeah, I honestly hadn't thought much about filtering on a struct column until today :/
My statement is mostly an observation that there is currently no way to write a DNF filter argument that would be translated into the appropriate PyArrow filter expression (at least I don't think there is), and we would handle such a filter wrong in _get_rg_statistics anyway... All the more reason for a direct from_arrow_dataset API ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken dataframe io
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants