Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fea/update-worker #140

Merged
merged 13 commits into from
Apr 6, 2021
Merged

fea/update-worker #140

merged 13 commits into from
Apr 6, 2021

Conversation

quasiben
Copy link
Member

@quasiben quasiben commented Mar 8, 2021

PR replaces usage of Nanny in the worker with dask_spec. Using dask_spec users can can define worker_classes and worker_options in an effort to mimic the style of deployment leveraged in dask-cloudprovider

@ayushdg
Copy link

ayushdg commented Mar 23, 2021

Thanks for this @quasiben. I was able to use this pr to spin up dask-cuda workers using the worker_class argument. Is there any more work needed here before it can be reviewed/merged?

Side question (not directly related to the PR): Is it possible to spin up workers on the main (master) node as well?

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me!

I'm not super familiar with this project so asked a couple of questions, but feel free to dismiss them.

dask_yarn/cli.py Show resolved Hide resolved
dask_yarn/cli.py Show resolved Hide resolved
@quasiben
Copy link
Member Author

quasiben commented Apr 6, 2021

Thanks for the comments @jacobtomlinson !

@quasiben quasiben force-pushed the fea/update-worker branch from 5414acc to b08b8dd Compare April 6, 2021 16:37
@quasiben
Copy link
Member Author

quasiben commented Apr 6, 2021

Thanks merging in and we'll release shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants