Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update theme for rebranding #67

Merged
merged 10 commits into from
Jun 6, 2022
Merged

Conversation

scharlottej13
Copy link
Contributor

@scharlottej13 scharlottej13 commented May 5, 2022

Update Dask docs design in line with rebranding efforts in dask/community#220. Changes include updated Dask logo, color palettes, and fonts.

To do:

Here are a couple screenshots for comparison:

current docs
Screen Shot 2022-05-05 at 3 44 26 PM

changes in this PR
Screen Shot 2022-05-31 at 10 49 45 PM

cc @jacobtomlinson @AdiReske @jrbourbeau @jsignell

@scharlottej13 scharlottej13 changed the title Draft - Update fonts, colors [do not merge!] Draft - Update fonts, colors Jun 1, 2022
@AdiReske
Copy link

AdiReske commented Jun 1, 2022

Thank you!!

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great thanks @scharlottej13.

I see you have a few unchecked tasks but I would be more than happy to merge this as is and iterate after that.

I'll merge this on Monday as part of the new website rollout.

@jsignell
Copy link
Member

jsignell commented Jun 1, 2022

Yeah I like that plan to merge and iterate. The docs won't be rebuilt until the next release unless we specifically trigger them in readthedocs.

@scharlottej13 scharlottej13 changed the title Draft - Update fonts, colors Update theme for rebranding Jun 1, 2022
@scharlottej13 scharlottej13 marked this pull request as ready for review June 1, 2022 19:32
@scharlottej13
Copy link
Contributor Author

scharlottej13 commented Jun 1, 2022

Sounds good @jsignell and @jacobtomlinson, thanks for taking a look!

Since @jrbourbeau fixed the RTD build, if you (or others) have bandwidth to click through some of the docs pages, that would be great. Of course, I can also make more changes after "going live" on 6/6. Sorry, realized that doesn't actually make sense!

@scharlottej13
Copy link
Contributor Author

The docs won't be rebuilt until the next release unless we specifically trigger them in readthedocs.

@jsignell does this mean triggering a docs build separately for each project (e.g. dask-ml, dask-distributed`, etc.)? And, if so, @jacobtomlinson does it make sense to merge these PRs today or tomorrow instead? I haven't triggered a rebuild in readthedocs before (I don't think I have permission to do so), but happy to do so if someone doesn't mind walking me through the steps.

cc @jrbourbeau

@jacobtomlinson
Copy link
Member

Id rather wait until the website is live on Monday.

We need to merge here, tag a release, potential update pinned versions in downstream projects and then rebuild the docs sites on each of those.

In most cases rebuilding the downstream docs sites involves merging a PR to main.

@scharlottej13
Copy link
Contributor Author

scharlottej13 commented Jun 2, 2022

We need to merge here, tag a release, potential update pinned versions in downstream projects and then rebuild the docs sites on each of those.

I can open up PRs to update the pinned versions in downstream projects. From the release history looks like it will be 2.0.4?

In most cases rebuilding the downstream docs sites involves merging a PR to main.

@jacobtomlinson would it be helpful for me to open placeholder PRs in downstream docs sites to make this easier? The downstream sites I have include (going down the list of repos):

  • distributed
  • dask-tutorial
  • dask-kubernetes
  • dask-cloudprovider
  • dask-ml
  • dask-gateway
  • dask-examples
  • dask-image
  • dask-stories
  • dask-blog
  • dask-mpi
  • dask-jobqueue
  • dask-yarn
  • ? dask-glm

Also, thanks for answering all my questions! Just trying to figure out what the steps are and how I can help.

@jacobtomlinson
Copy link
Member

That would be super helpful! Anything that's not marked as archived on GitHub will need updating.

I think given this is a major rebrand we should tag version 3.0.0 though.

@scharlottej13
Copy link
Contributor Author

That would be super helpful! Anything that's not marked as archived on GitHub will need updating.

I think given this is a major rebrand we should tag version 3.0.0 though.

Perfect! I'll open those PRs up today and will tag you two in them @jacobtomlinson and @jsignell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants