Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic backend dispatching to dask-expr #728
Add basic backend dispatching to dask-expr #728
Changes from all commits
e1edd8a
24ce9a4
f2e5404
217836c
5acdbc9
9081084
3d7b37f
9f753ab
ab095a7
949f45a
cdea6d5
cde64ad
47432a6
4521d7c
0694d39
4681adf
aa54da8
d4319ec
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that we have been using
new_collection
from the beginning, because we knew we needed to make this change to support other backends (i.e. cudf) long term.The behavior of
new_collection
is now consistent with the behavior ofnew_dd_object
indask.dataframe
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we will need many dispatch functions here. So, we could also define this in
dask.datafame.dispatch
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now publicly exposed as
dask_expr.get_collection_type
. This can always be moved todask.datafame.dispatch
in the future.