Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TIMESTAMPDIFF support #876

Merged
merged 10 commits into from
Nov 30, 2022
Merged

Conversation

sarahyurick
Copy link
Collaborator

Closes #852

@sarahyurick sarahyurick marked this pull request as ready for review October 24, 2022 17:48
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2022

Codecov Report

Merging #876 (2d395a2) into main (9cce9be) will increase coverage by 0.35%.
The diff coverage is 96.66%.

@@            Coverage Diff             @@
##             main     #876      +/-   ##
==========================================
+ Coverage   75.44%   75.80%   +0.35%     
==========================================
  Files          73       73              
  Lines        4020     4050      +30     
  Branches      721      731      +10     
==========================================
+ Hits         3033     3070      +37     
+ Misses        826      815      -11     
- Partials      161      165       +4     
Impacted Files Coverage Δ
dask_sql/physical/rex/core/call.py 81.02% <96.66%> (+0.98%) ⬆️
dask_sql/_version.py 35.31% <0.00%> (+1.41%) ⬆️
dask_sql/mappings.py 87.25% <0.00%> (+2.94%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust changes LGTM

@ayushdg ayushdg merged commit d2896fa into dask-contrib:main Nov 30, 2022
@sarahyurick sarahyurick deleted the timestampdiff branch May 26, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Support TIMESTAMPDIFF
4 participants