Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set max pin on antlr4-python-runtime #456

Merged
merged 2 commits into from
Apr 12, 2022
Merged

Set max pin on antlr4-python-runtime #456

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6611609
Set max pin on antlr4-python-runtime due to incompatibilities with fu…
ayushdg Apr 12, 2022
5ed53a2
update comment on antlr max pin version
ayushdg Apr 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion continuous_integration/environment-3.10-jdk11-dev.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ channels:
- nodefaults
dependencies:
- adagio>=0.2.3
- antlr4-python3-runtime>=4.9.2
- antlr4-python3-runtime>=4.9.2, <4.10.0 # Max pin until https://github.com/fugue-project/fugue/issues/318 is resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like fugue-project/fugue#318 should have been resolved with fugue 0.6.6; maybe we should swap out this comment to say that the problem occurs with fugue<0.6.6?

Copy link
Collaborator Author

@ayushdg ayushdg Apr 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I'll update the comment but just as a quick note since we get fugue from pip, the pip dependencies don't really impact what the conda solver picks up, so we'd need to keep this pin around even if we bump our fugue version to 0.6.6

- black=22.3.0
- ciso8601>=2.2.0
- dask-ml>=2022.1.22
Expand Down
2 changes: 1 addition & 1 deletion continuous_integration/environment-3.10-jdk8-dev.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ channels:
- nodefaults
dependencies:
- adagio>=0.2.3
- antlr4-python3-runtime>=4.9.2
- antlr4-python3-runtime>=4.9.2, <4.10.0 # Max pin until https://github.com/fugue-project/fugue/issues/318 is resolved
- black=22.3.0
- ciso8601>=2.2.0
- dask-ml>=2022.1.22
Expand Down
2 changes: 1 addition & 1 deletion continuous_integration/environment-3.8-jdk11-dev.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ channels:
- nodefaults
dependencies:
- adagio>=0.2.3
- antlr4-python3-runtime>=4.9.2
- antlr4-python3-runtime>=4.9.2, <4.10.0 # Max pin until https://github.com/fugue-project/fugue/issues/318 is resolved
- black=22.3.0
- ciso8601>=2.2.0
- dask-ml>=2022.1.22
Expand Down
2 changes: 1 addition & 1 deletion continuous_integration/environment-3.8-jdk8-dev.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ channels:
- nodefaults
dependencies:
- adagio>=0.2.3
- antlr4-python3-runtime>=4.9.2
- antlr4-python3-runtime>=4.9.2, <4.10.0 # Max pin until https://github.com/fugue-project/fugue/issues/318 is resolved
- black=22.3.0
- ciso8601>=2.2.0
- dask-ml>=2022.1.22
Expand Down
2 changes: 1 addition & 1 deletion continuous_integration/environment-3.9-jdk11-dev.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ channels:
- nodefaults
dependencies:
- adagio>=0.2.3
- antlr4-python3-runtime>=4.9.2
- antlr4-python3-runtime>=4.9.2, <4.10.0 # Max pin until https://github.com/fugue-project/fugue/issues/318 is resolved
- black=22.3.0
- ciso8601>=2.2.0
- dask-ml>=2022.1.22
Expand Down
2 changes: 1 addition & 1 deletion continuous_integration/environment-3.9-jdk8-dev.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ channels:
- nodefaults
dependencies:
- adagio>=0.2.3
- antlr4-python3-runtime>=4.9.2
- antlr4-python3-runtime>=4.9.2, <4.10.0 # Max pin until https://github.com/fugue-project/fugue/issues/318 is resolved
- black=22.3.0
- ciso8601>=2.2.0
- dask-ml>=2022.1.22
Expand Down