Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for gpu kwarg in Context.sql and explain #368

Merged
merged 3 commits into from
Jan 13, 2022

Conversation

charlesbluca
Copy link
Collaborator

While working on #365, I noticed that Context.sql and explain both allow dataframes to be input directly, prompting the corresponding create_table calls before executing.

This PR adds the gpu kwarg to these methods, to be passed to the underlying create_table calls.

Copy link
Collaborator

@ayushdg ayushdg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me and should be good to merge once CI passes.

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2022

Codecov Report

Merging #368 (70e89e4) into main (6040f00) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #368   +/-   ##
=======================================
  Coverage   95.57%   95.57%           
=======================================
  Files          67       67           
  Lines        2935     2935           
  Branches      547      547           
=======================================
  Hits         2805     2805           
  Misses         79       79           
  Partials       51       51           
Impacted Files Coverage Δ
dask_sql/context.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6040f00...70e89e4. Read the comment docs.

@charlesbluca charlesbluca merged commit 286681f into dask-contrib:main Jan 13, 2022
@charlesbluca charlesbluca deleted the dataframes-gpu branch January 19, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants