Add support for optional catalog name to SHOW SCHEMAS | TABLES
#1063
Conversation
| catalog_name = show_schemas.getFrom() or context.catalog_name | ||
| if catalog_name != context.catalog_name: | ||
| raise RuntimeError( | ||
| f"A catalog with the name {catalog_name} is not present." | ||
| ) |
There was a problem hiding this comment.
For now, we are able to parse statements like SHOW SCHEMAS FROM "dask_sql", but fail in any case where the catalog name isn't dask_sql; I figured it would make more sense to actually bother refactoring the Python handling of catalogs once we add functionality to add/remove/switch catalogs through queries.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1063 +/- ##
==========================================
- Coverage 81.75% 79.55% -2.21%
==========================================
Files 78 78
Lines 4380 4387 +7
Branches 788 790 +2
==========================================
- Hits 3581 3490 -91
- Misses 626 720 +94
- Partials 173 177 +4
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
charlesbluca
changed the title
SHOW SCHEMAS FROM <catalog-name>SHOW SCHEMAS | TABLES
|
@charlesbluca just wanted to share this here since we talked about this today. Seems like after this merges things should be much more straightforward here. |
charlesbluca
requested review from
ayushdg,
galipremsagar and
jdye64
as code owners
| gpuci_logger "Install latest dask-cuda" | ||
| gpuci_mamba_retry update -y -c rapidsai-nightly dask-cuda | ||
|
|
There was a problem hiding this comment.
Don't think this should be necessary anymore? Removing because the recent pinning of dask/distributed in dask-cuda nightlies is causing GPU failures due to the order of install here
WIP to unblock some of the functionality of Metabase using its deprecated Presto driver with our server implementation.
TODO:
SHOW TABLES FROM <catalog-name>.<schema-name>