Remove EliminateAggDistinct optimizer rule, implement distinct aggs in Python
#1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1006 +/- ##
==========================================
+ Coverage 80.47% 80.60% +0.13%
==========================================
Files 75 75
Lines 4231 4234 +3
Branches 765 766 +1
==========================================
+ Hits 3405 3413 +8
+ Misses 662 653 -9
- Partials 164 168 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ayushdg
requested changes
Jan 24, 2023
ayushdg
approved these changes
Jan 26, 2023
ayushdg
requested review from
andygrove,
galipremsagar and
jdye64
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to remove the
EliminateAggDistinctoptimizer rule and instead handle distinct aggregations directly from the Python aggregate plugin usingdrop_duplicates.This ideally should unblock the groupby related failures cropping up in #998 and resolve the existing groupby agg failures that we had seen in test_compatibility.py.