Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(rs-drive-abci): update Dockerfile to Alpine and build correctly on ARM64 #859

Merged
merged 4 commits into from
Apr 1, 2023

Conversation

lklimek
Copy link
Contributor

@lklimek lklimek commented Mar 24, 2023

Issue being fixed or feature implemented

As learned from dashpay/rs-tenderdash-abci#14 , cargo build takes too many resources on ARM64 target in github actions. This causes Arm64 image build to fail.

What was done?

Added --config net.git-fetch-with-cli=true to address ARM build issue. See rust-lang/cargo#10781 (comment)

Replace Debian base image with Apline.

How Has This Been Tested?

On rs-tenderdash-abci, similar solution fixed the arm64 build issue: https://github.com/dashpay/rs-tenderdash-abci/actions/runs/4512281223

Locally, it also passes:

docker buildx build --platform linux/arm64,linux/amd64 -f packages/rs-drive-abci/Dockerfile .

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek marked this pull request as ready for review March 24, 2023 16:42
@lklimek lklimek requested review from strophy and removed request for shumkov and antouhou March 24, 2023 16:42
@lklimek lklimek changed the title build(rs-drive-abci): Update Dockerfile to build correctly on ARM64 build(rs-drive-abci): Update Dockerfile to Alpine and build correctly on ARM64 Mar 29, 2023
@shumkov shumkov changed the title build(rs-drive-abci): Update Dockerfile to Alpine and build correctly on ARM64 build(rs-drive-abci): update Dockerfile to Alpine and build correctly on ARM64 Mar 29, 2023
@lklimek lklimek requested a review from shumkov March 30, 2023 15:01
@lklimek lklimek merged commit 3a1a06d into phoenix Apr 1, 2023
@lklimek lklimek deleted the fix-docker-arm branch April 1, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants