Fixes getTransactionHistory.js and Identity.spec.js

dashpay · Mar 1, 2022 · 3ba7213 · 3ba7213
1 parent eb6ee75
commit 3ba7213
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 12 deletions.
diff --git a/packages/platform-test-suite/test/functional/platform/Identity.spec.js b/packages/platform-test-suite/test/functional/platform/Identity.spec.js
@@ -15,10 +15,10 @@ const BalanceIsNotEnoughError = require('@dashevo/dpp/lib/errors/consensus/fee/B
 const DAPIClient = require('@dashevo/dapi-client/lib/DAPIClient');
 const { hash } = require('@dashevo/dpp/lib/util/hash');
 const Identifier = require('@dashevo/dpp/lib/identifier/Identifier');
+const Transaction = require('@dashevo/dashcore-lib/lib/transaction');
 const createClientWithFundedWallet = require('../../../lib/test/createClientWithFundedWallet');
 const wait = require('../../../lib/wait');
 const getDAPISeeds = require('../../../lib/test/getDAPISeeds');
-const Transaction = require('@dashevo/dashcore-lib/lib/transaction');
 
 describe('Platform', () => {
   describe('Identity', () => {
@@ -114,11 +114,12 @@ describe('Platform', () => {
         await wait(5000);
       }
 
-      walletAccount.storage.insertIdentityIdAtIndex(
-        walletAccount.walletId,
-        identityOne.getId().toString(),
-        identityOneIndex,
-      );
+      walletAccount.storage
+        .getWalletStore(walletAccount.walletId)
+        .insertIdentityIdAtIndex(
+          identityOne.getId().toString(),
+          identityOneIndex,
+        );
 
       // Creating transition that tries to spend the same transaction
       const {

diff --git a/packages/wallet-lib/src/types/Account/methods/getTransactionHistory.js b/packages/wallet-lib/src/types/Account/methods/getTransactionHistory.js
@@ -22,9 +22,17 @@ function getTransactionHistory() {
     network,
   } = this;
 
-  const transactionsWithMetadata = this.getTransactions();
+  const transactions = this.getTransactions();
+
   const walletStore = storage.getWalletStore(walletId);
   const chainStore = storage.getChainStore(network);
+
+  const transactionsWithMetadata = Object.keys(transactions).reduce((acc, hash) => {
+    const { metadata } = chainStore.getTransaction(hash);
+    acc.push([transactions[hash], metadata]);
+    return acc;
+  }, []);
+
   const { blockHeaders } = chainStore.state;
 
   const categorizedTransactions = categorizeTransactions(

diff --git a/packages/wallet-lib/src/types/Account/methods/getTransactions.spec.js b/packages/wallet-lib/src/types/Account/methods/getTransactions.spec.js
@@ -11,11 +11,8 @@ mockedHDSelf.getTransactions = getTransactions;
 describe('Account - getTransactions', function suite() {
   this.timeout(10000);
   it('should get the transactions', () => {
-    const transactionsWithMetadata = getTransactions.call(mockedHDSelf);
-    const transactionsHash = transactionsWithMetadata.reduce((acc, el)=>{
-      acc.push(el[0].hash);
-      return acc;
-    },[]);
+    const transactions = getTransactions.call(mockedHDSelf);
+    const transactionsHash = Object.keys(transactions);
 
     expect(transactionsHash).to.deep.equal([
       'a43845e580ad01f31bc06ce47ab39674e40316c4c6b765b6e54d6d35777ef456',