-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(rpc): add new rpcs #97
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@knst @ogabrielides pls double check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a comment
| Name | Type | Presence | Description | | ||
| ------- | ----- | -------- | ----------- | | ||
| Indexes | array | Required | An array of Asset Unlock indexes (no more than 100). Each element is a numeric Asset Unlock index. | | ||
| height | numeric | Optional (0 or 1) | The maximum block height to check. If not specified, the chain's tip is used. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this (0 or 1)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That field can be confusing. It means the field is optional and there can be either 0 instances of the field or 1. For some things (e.g. arrays) this could say "0 or more", for example. This was the way it was in the bitcoin docs we started with and we've never changed it.
* docs(rpc): add getrawtransactionmulti * docs(rpc): update quick reference * docs(rpc): fix urls * docs(rpc): add internal links * feat: add getassetunlockstatuses * docs: update quick ref with new rpc * doc: make see also consistent on page * docs: add new rpc to quick ref * style: consistent formatting * docs: add submitchainlock rpc * docs: minor update * docs: consolidate params table * docs: address review comments
* docs(rpc): add getrawtransactionmulti * docs(rpc): update quick reference * docs(rpc): fix urls * docs(rpc): add internal links * feat: add getassetunlockstatuses * docs: update quick ref with new rpc * doc: make see also consistent on page * docs: add new rpc to quick ref * style: consistent formatting * docs: add submitchainlock rpc * docs: minor update * docs: consolidate params table * docs: address review comments
Preview build: https://dash-docs--97.org.readthedocs.build/projects/core/en/97/