Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(rpc): add new rpcs #97

Merged
merged 13 commits into from
Feb 8, 2024
Merged

Conversation

thephez
Copy link
Collaborator

@thephez thephez commented Feb 1, 2024

@thephez thephez changed the title docs(rpc): add getrawtransactionmulti docs(rpc): add new rpcs Feb 5, 2024
@thephez thephez requested a review from UdjinM6 February 5, 2024 19:01
Copy link
Contributor

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knst @ogabrielides pls double check

Copy link
Collaborator

@ogabrielides ogabrielides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a comment

| Name | Type | Presence | Description |
| ------- | ----- | -------- | ----------- |
| Indexes | array | Required | An array of Asset Unlock indexes (no more than 100). Each element is a numeric Asset Unlock index. |
| height | numeric | Optional (0 or 1) | The maximum block height to check. If not specified, the chain's tip is used. |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this (0 or 1) ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That field can be confusing. It means the field is optional and there can be either 0 instances of the field or 1. For some things (e.g. arrays) this could say "0 or more", for example. This was the way it was in the bitcoin docs we started with and we've never changed it.

@thephez thephez merged commit c9406b1 into dashpay:develop Feb 8, 2024
@thephez thephez deleted the v20.1-rpc-updates-2 branch February 8, 2024 14:08
thephez added a commit to thephez/docs-core that referenced this pull request Mar 5, 2024
* docs(rpc): add getrawtransactionmulti

* docs(rpc): update quick reference

* docs(rpc): fix urls

* docs(rpc): add internal links

* feat: add getassetunlockstatuses

* docs: update quick ref with new rpc

* doc: make see also consistent on page

* docs: add new rpc to quick ref

* style: consistent formatting

* docs: add submitchainlock rpc

* docs: minor update

* docs: consolidate params table

* docs: address review comments
thephez added a commit to thephez/docs-core that referenced this pull request Aug 22, 2024
* docs(rpc): add getrawtransactionmulti

* docs(rpc): update quick reference

* docs(rpc): fix urls

* docs(rpc): add internal links

* feat: add getassetunlockstatuses

* docs: update quick ref with new rpc

* doc: make see also consistent on page

* docs: add new rpc to quick ref

* style: consistent formatting

* docs: add submitchainlock rpc

* docs: minor update

* docs: consolidate params table

* docs: address review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants