Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add readthedocs-sphinx-search #50

Merged
merged 11 commits into from
Jul 19, 2023

Conversation

thephez
Copy link
Collaborator

@thephez thephez commented Jul 13, 2023

Replace pydata theme's built-in search with search as you type
Note: for an unknown reason, the PR build doesn't actually have functional search. It can be previewed on this build of the branch itself which does work and is presumably reflective of how it will actually work when merged: https://dash-user-docs.readthedocs.io/projects/core/en/v19-rtd-sphinx-search

Current view in light/dark modes:
image
image

https://dash-docs--50.org.readthedocs.build/projects/core/en/50/

Replace pydata theme's built-in search with search as you type
@thephez thephez force-pushed the v19-rtd-sphinx-search branch 3 times, most recently from 00e9fbe to c3dc3fd Compare July 17, 2023 18:53
@thephez thephez force-pushed the v19-rtd-sphinx-search branch from c3dc3fd to 934c80e Compare July 17, 2023 19:03
@thephez thephez force-pushed the v19-rtd-sphinx-search branch from 8627009 to 2c0f841 Compare July 18, 2023 15:43
@thephez thephez force-pushed the v19-rtd-sphinx-search branch from cc07740 to e3915c8 Compare July 18, 2023 16:43
@thephez thephez force-pushed the v19-rtd-sphinx-search branch from ba3651b to bebf1dd Compare July 18, 2023 17:25
@thephez thephez force-pushed the v19-rtd-sphinx-search branch from 9e4cf73 to c8cf3cb Compare July 18, 2023 18:09
@thephez thephez force-pushed the v19-rtd-sphinx-search branch from a22b703 to 5b23623 Compare July 18, 2023 19:23
@thephez thephez marked this pull request as ready for review July 18, 2023 19:31
@thephez thephez requested review from strophy and rmdash July 18, 2023 19:31
@thephez
Copy link
Collaborator Author

thephez commented Jul 18, 2023

@rmdash @strophy Somewhat a proof-of-concept, but it seems to work. The visual appeal could definitely be improved by a CSS expert. Looking for feedback on actually using this search option and how much more should be done before merging.

Probably a fitting meme for this effort...
image

@rmdash
Copy link
Contributor

rmdash commented Jul 18, 2023

@rmdash @strophy Somewhat a proof-of-concept, but it seems to work. The visual appeal could definitely be improved by a CSS expert. Looking for feedback on actually using this search option and how much more should be done before merging.

Probably a fitting meme for this effort... image

Ser, you get a cookie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants